Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the search note functionality #2676

Closed
wants to merge 1 commit into from
Closed

Fix the search note functionality #2676

wants to merge 1 commit into from

Conversation

richardtks
Copy link
Contributor

@richardtks richardtks commented Dec 3, 2018 •
edited
Loading

Description

Previously, the search will be executed only when the backspace key is entered. After the fix, the search start as soon as the user enter the character to the input.

fix-search-note

Issue fixed

#2015

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 6, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 8, 2018

I'm not familiar with this CompositionEvent so I'll also need review from @Rokt33r

@ZeroX-DG ZeroX-DG requested a review from Rokt33r December 8, 2018 10:17
@Rokt33r
Copy link
Member

Rokt33r commented Dec 13, 2018

@richardtks I cannot confirm the problem yet. How did you reproduce the problem?

@Rokt33r
Copy link
Member

Rokt33r commented Dec 13, 2018

@ZeroX-DG Can you reproduce the bug?

@richardtks
Copy link
Contributor Author

@Rokt33r Hi, I able to reproduce by just simply typing the words that I want to search and it did not reflect on the list until I enter backspace.

search_issue

I am using Ubuntu LTS 16.

@Rokt33r
Copy link
Member

Rokt33r commented Dec 13, 2018

@richardtks Thanks. I'll try again in Ubuntu. 👍

@Rokt33r
Copy link
Member

Rokt33r commented Dec 24, 2018

@richardtks Sorry for late response. I tried it on Ubuntu v18. It works fine. Which input system are you using?

@richardtks
Copy link
Contributor Author

@Rokt33r, I am using ibus. What input system you are using?

@Rokt33r
Copy link
Member

Rokt33r commented Dec 24, 2018

Hmm... that's weird. I'm using ibus too. Maybe should I check it with Chinese keyboard?

@richardtks
Copy link
Contributor Author

@Rokt33r, weird, I am using ibus-chinese. maybe this only happens to ibus-chinese....

@Rokt33r
Copy link
Member

Rokt33r commented Dec 25, 2018

I'm really afraid that this change might interfere with other input system with other languages and other OSs.... Hmm... give me more time to check all of them.

  • Windows / Chinese
  • Windows / Japanese
  • macOS / Chinese
  • macOS / Japanese
  • Ubuntu / Japanese

@AWolf81 AWolf81 mentioned this pull request May 26, 2019
Merged
2 tasks
@amedora
Copy link
Contributor

amedora commented Jul 23, 2019

resolved by #3037 already.

@ZeroX-DG
Copy link
Member

Sorry @richardtks I'll have to close this PR. Thank you very much for the effort anyway ❤️

@ZeroX-DG ZeroX-DG closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardtks @ZeroX-DG @Rokt33r @amedora